Skip to content

Fix ServerAdditionalSettings to allow method calls in any order #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ServerAdditionalSettings to allow method calls in any order #3919

wants to merge 1 commit into from

Conversation

drganjoo
Copy link
Contributor

Previously, calling generateCodegenComments() before other methods would fail because it returned the parent type AdditionalSettings instead of ServerAdditionalSettings. For example, this code would fail:

IntegrationTestParams(
    additionalSettings =
        ServerAdditionalSettings()
            .generateCodegenComments(true)
            .addValidationExceptionToConstrainedOperations()  // Compilation error: Cannot resolve this reference
            .build(),
),

Fix ServerAdditionalSettings to allow method calls in any order
6d65526 
Previously, calling generateCodegenComments() before other methods would
fail because it returned the parent type. Modified the class to maintain
the correct type throughout method chaining.
@drganjoo drganjoo force-pushed the fahadzub/fix-server-settings branch from 8eae004 to 6d65526 Compare November 21, 2024 12:29
@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@drganjoo drganjoo marked this pull request as ready for review November 21, 2024 19:29
@drganjoo drganjoo requested review from a team as code owners November 21, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drganjoo